Upgrade stringtemplate to version 4 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stringtemplate3 is very outdated (last commit in 2015) and depends on a outdated version of antlr. It's causing this issue: 47degrees/sbt-microsites#457 - The `setAttributes` method in stringtemplate3 was always broken, as it goes down a different code path compared to `setAttribute` in stringtemplate3. See [setAttributes](https://github.com/antlr/stringtemplate3/blob/e60b23544539d64d2f57a87e87a5b383cc2b0ba9/src/org/antlr/stringtemplate/StringTemplate.java#L918) and [setAttribute](https://github.com/antlr/stringtemplate3/blob/e60b23544539d64d2f57a87e87a5b383cc2b0ba9/src/org/antlr/stringtemplate/StringTemplate.java#L570) for details, Stringtemplate4 removed the `setAttributes` method, so I had to write a custom function to handle the '.' characters in the properties.
eed3si9n
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stringtemplate3 is very outdated (last commit in 2015) and depends on a
outdated version of antlr. It's causing this issue: Error while trying to use with Intellij: not found: https://repo1.maven.org/maven2/antlr/antlr/2.7.7/antlr-2.7.7-sources.jar 47degrees/sbt-microsites#457
The
setAttributesmethod in stringtemplate3 was always broken,as it goes down a different code path compared to
setAttributeinstringtemplate3.
See setAttributes and setAttribute for details,
Stringtemplate4 removed the
setAttributesmethod, so I had to write acustom function to handle the '.' characters in the properties.