Automates physical resistance for Inspire Heroics (Defense) effects #20725
Conversation
Adds resistance rules elements to Inspire Heroics (Defense) spell effects. Also renames them to match remastered Rallying Anthem, and updated description to reflect added rules element.
|
Rallying Anthem has a dedicated effect. I believe we are keeping this effect as is for Legacy purposes (aka folks still using the Legacy version of the class. A data lead can potentially confirm or refute this. |
Thank you for the info, the motivation for creating this PR was that the Workbench macro for Fortissimo uses this spell effect but in that case it would probably be better to add a new effect there. The legacy Inspire Defense does provide resistance as well though. |
| "_id": "Chol7ExtoN2T36mP", | ||
| "img": "systems/pf2e/icons/spells/inspire-heroics.webp", | ||
| "name": "Spell Effect: Inspire Heroics (Defense, +2)", | ||
| "name": "Spell Effect: Inspire Heroics (Rallying, +2)", |
There was a problem hiding this comment.
| "name": "Spell Effect: Inspire Heroics (Rallying, +2)", | |
| "name": "Spell Effect: Inspire Heroics (Defense, +2)", |
| { | ||
| "key": "FlatModifier", | ||
| "label": "Inspire Defense", | ||
| "label": "Rallying Anthem", |
There was a problem hiding this comment.
| "label": "Rallying Anthem", |
| "_id": "BKam63zT98iWMJH7", | ||
| "img": "systems/pf2e/icons/spells/inspire-heroics.webp", | ||
| "name": "Spell Effect: Inspire Heroics (Defense, +3)", | ||
| "name": "Spell Effect: Inspire Heroics (Rallying, +3)", |
There was a problem hiding this comment.
| "name": "Spell Effect: Inspire Heroics (Rallying, +3)", | |
| "name": "Spell Effect: Inspire Heroics (Defense, +3)", |
| { | ||
| "key": "FlatModifier", | ||
| "label": "Inspire Defense", | ||
| "label": "Rallying Anthem", |
There was a problem hiding this comment.
| "label": "Rallying Anthem", |
There was a problem hiding this comment.
We shouldn't bother with the labels at all. Not only are they unlocalized and we don't really need to add new keys for legacy effects, but the system will already strip the Effect prefix as well as the parentheticals.
3 participants
Adds resistance rules elements to Inspire Heroics (Defense) spell effects.
Renames effects and labels to match remastered name Rallying Anthem.
Updates descriptions to reflect added rules element.