Skip to content

Fix invalid item Documents preventing all physical item updates #20652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v13-dev
Choose a base branch
from
+7 −1
Open

Fix invalid item Documents preventing all physical item updates #20652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/module/item/physical/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,13 @@ function handleHPChange(item: PhysicalItemPF2e, changed: DeepPartial<PhysicalIte
const itemIndex = actorSource?.items.findIndex((i) => i._id === item._id);
if (itemIndex === -1) return;
actorSource?.items.splice(itemIndex ?? 0, 1, changedSource);
const actorClone = actorSource ? new ActorProxyPF2e(actorSource) : null;
const actorClone = ((): ActorPF2e | null => {
// Catch invalid items in the actor clone preventing other items from updating
try {
return actorSource ? new ActorProxyPF2e(actorSource) : null;
} catch {}
return null;
})();
const itemClone = actorClone?.inventory.get(item.id, { strict: true }) ?? item.clone(changed, { keepId: true });

// Adjust current HP proportionally if max HP changed
Expand Down