Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strk as a default fee token #2749

Merged
merged 30 commits into from
Dec 13, 2024
Merged

Use strk as a default fee token #2749

merged 30 commits into from
Dec 13, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Dec 3, 2024 •
edited
Loading

Closes #2696

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula changed the title Kkawula/2696 use strk as a default fee token 2696 use strk as a default fee token Dec 3, 2024
@kkawula kkawula changed the title 2696 use strk as a default fee token Use strk as a default fee token Dec 9, 2024
@kkawula kkawula marked this pull request as ready for review December 9, 2024 07:44
cptartur
cptartur requested changes Dec 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
docs/src/starknet/fees-and-versions.md Outdated Show resolved Hide resolved
@kkawula kkawula requested a review from cptartur December 10, 2024 16:43
cptartur
cptartur reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also make sense to show the deprecation warning when using v1 version. But this could be a separate PR.

crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
@kkawula kkawula requested a review from cptartur December 11, 2024 09:49
ddoktorski
ddoktorski reviewed Dec 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
cptartur
cptartur reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test asserting that both warnings that were added by you display correctly and in correct cases?

crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
crates/sncast/src/helpers/fee.rs Show resolved Hide resolved
docs/src/starknet/fees-and-versions.md Outdated Show resolved Hide resolved
@kkawula
Copy link
Collaborator Author

kkawula commented Dec 13, 2024

I think it would also make sense to show the deprecation warning when using v1 version. But this could be a separate PR.

#2774

@cptartur cptartur removed their request for review December 13, 2024 11:41
@kkawula kkawula requested a review from cptartur December 13, 2024 12:43
cptartur
cptartur approved these changes Dec 13, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
kkawula
kkawula commented Dec 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kkawula kkawula enabled auto-merge December 13, 2024 13:22
@kkawula kkawula added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 7e4ba6b Dec 13, 2024
26 checks passed
@kkawula kkawula deleted the kkawula/2696-use-strk-as-a-default-fee-token branch December 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use strk as a default --fee-token
3 participants
@kkawula @ddoktorski @cptartur