Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run some checks on windows #2730

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
ea31dd2
Run some checks on windows
cptartur Nov 29, 2024
3fb3906
Remove linux specific expected message
cptartur Nov 29, 2024
5ebc63a
Run 2.8.3 only on ubuntu-latest
cptartur Nov 29, 2024
b738f12
Ignore fork related integration tests on windows
cptartur Nov 29, 2024
a7e4b4b
Ignore fork related integration tests on windows
cptartur Nov 29, 2024
864818a
Do not run coverage and profiler tests on windows
cptartur Nov 29, 2024
6c7cb45
Add install_devnet.ps1
cptartur Nov 29, 2024
72fd826
Run install_devnet.ps1 on windows
cptartur Nov 29, 2024
f4e15ea
Fix nextest platform specific uploads
cptartur Nov 29, 2024
527325b
Always run step in bash
cptartur Nov 29, 2024
cccb52b
Change path on windows
cptartur Nov 29, 2024
49b9ab4
Fix path to platform
cptartur Nov 29, 2024
75dfa7d
Fix tag name in install_devnet.ps1
cptartur Nov 29, 2024
3a849d8
Du not run forking e2e tests in windows
cptartur Nov 29, 2024
462d546
Add `--no-fail-fast` to forge e2e tests
cptartur Nov 29, 2024
31ec41f
Add different installation steps for windows and Linux/macOS
cptartur Nov 29, 2024
198ba82
Always run e2e prep steps using bash
cptartur Dec 2, 2024
0221ce3
Disable `setup_fork::incompatible_abi` on windows
cptartur Dec 2, 2024
a6a9b5e
Merge branch 'master' into 2716-run-tests-on-windows
cptartur Dec 2, 2024
97b7eb0
Disable `cheat_fork::store_load_cairo0_contract` on windows
cptartur Dec 2, 2024
1945681
System specific devnet path
cptartur Dec 2, 2024
45c531d
System specific devnet killing
cptartur Dec 2, 2024
5c9100c
Fix windows devnet path
cptartur Dec 2, 2024
e3f49d9
Remove os specific error from `test_invalid_private_key_file_path`
cptartur Dec 2, 2024
6c73d27
Remove os specific error from `test_directory_non_existent`
cptartur Dec 2, 2024
0a3384d
Handle `.exe` in sncast name in `test_no_output_path_specified`
cptartur Dec 2, 2024
ee04138
Remove os specific error from `test_invalid_path`
cptartur Dec 2, 2024
6707dc7
Remove os specific path from `test_initialized_script_compiles`
cptartur Dec 2, 2024
ea8c9af
Use different scripts depending on the os
cptartur Dec 2, 2024
988d6d7
Use powershell on windows
cptartur Dec 2, 2024
fad159a
Fix powershell syntax
cptartur Dec 2, 2024
0b7af36
Remove unused constant
cptartur Dec 2, 2024
a2c3d0a
Use strings in `format!` directly
cptartur Dec 2, 2024
9dbfada
Sanitise file name for traces
cptartur Dec 2, 2024
a9eeefe
Merge branch 'master' into 2716-run-tests-on-windows
cptartur Dec 2, 2024
85dbaae
Replace `::` in file names
cptartur Dec 2, 2024
c5c994c
Disable fail-fast for matrix tests
cptartur Dec 2, 2024
4b2302f
Change trace related paths
cptartur Dec 3, 2024
8138b99
Remove os specific errors
cptartur Dec 3, 2024
115b2a7
Replace `::`
cptartur Dec 3, 2024
3924657
Force `lf` line endings on windows
cptartur Dec 3, 2024
f3cde99
Bypass powershell execution policy
cptartur Dec 3, 2024
3000fff
Force `lf` line endings on windows
cptartur Dec 3, 2024
e416b0c
Remove OS specific error
cptartur Dec 3, 2024
7fde1e7
Cache devnet on Windows
cptartur Dec 3, 2024
e3164ab
Fix path to devnet
cptartur Dec 3, 2024
3bb66d7
Make hard_test harder
cptartur Dec 3, 2024
4135145
Add missing ```
cptartur Dec 3, 2024
f95d30f
Build devnet cache
cptartur Dec 4, 2024
5085d32
Uncomment tests
cptartur Dec 4, 2024
023f4fa
Remove steps running non-existent test
cptartur Dec 4, 2024
000aa1d
Add newline to .gitattributes
cptartur Dec 5, 2024
10faf23
Use proper cfg for windows
cptartur Dec 5, 2024
10dde82
Restore tests order
cptartur Dec 5, 2024
b9527aa
Disable whole modules on windows
cptartur Dec 5, 2024
d9cefbc
Update asserts
cptartur Dec 5, 2024
c5f45ec
Add missing newline to install_devnet.ps1
cptartur Dec 5, 2024
84f40bf
Run profiler only on not windows
cptartur Dec 5, 2024
409eeab
Remove os specific asserts
cptartur Dec 5, 2024
34178da
Remove unnecessary profiler installation
cptartur Dec 9, 2024
92c025b
Mention trace file changes in CHANGELOG.md
cptartur Dec 9, 2024
833320c
Remove unnecessary todo
cptartur Dec 9, 2024
1a51b13
Use revision instead of tag
cptartur Dec 9, 2024
e9e18ed
Restore OS specific errors for files
cptartur Dec 10, 2024
04637a9
Lint, use reference
cptartur Dec 10, 2024
cbefce3
Fix windows error
cptartur Dec 10, 2024
e351f64
Fix windows error
cptartur Dec 10, 2024
0112d70
Use devnet revision on ci
cptartur Dec 10, 2024
aa534d1
Remove comments
cptartur Dec 10, 2024
91d8ec5
Update .github/workflows/ci.yml
cptartur Dec 10, 2024
8c209cc
Remove unnecessary test step
cptartur Dec 13, 2024
f641187
Merge branch 'master' into 2716-run-tests-on-windows
cptartur Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Run some checks on windows
cptartur committed Nov 29, 2024

Verified

This commit was signed with the committer’s verified signature.
aoyako Mykhailo Lohachov
commit ea31dd268a02397b73a2e79f29a94321a6d0a26f
36 changes: 26 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,10 @@ on:
jobs:
test-forge-unit-and-integration:
name: Test Forge / Unit and Integration Tests
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
@@ -23,7 +26,10 @@ jobs:
- run: cargo test --release integration -p forge

cptartur marked this conversation as resolved.
Show resolved Hide resolved
build-test-forge-e2e-nextest-archive:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
@@ -35,16 +41,17 @@ jobs:
- name: Upload archive to workflow
uses: actions/upload-artifact@v4
with:
name: nextest-archive
path: nextest-archive.tar.zst
name: nextest-archive-${{ matrix.os }}
path: nextest-archive-${{ matrix.os }}.tar.zst

test-forge-e2e:
name: Test Forge / E2E Tests
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
needs: build-test-forge-e2e-nextest-archive
strategy:
matrix:
partition: [ 1, 2, 3, 4, 5, 6, 7, 8 ]
os: [ ubuntu-latest, windows-latest ]
steps:
- name: Extract branch name
if: github.event_name != 'pull_request'
@@ -84,13 +91,16 @@ jobs:
- uses: taiki-e/install-action@nextest
- uses: actions/download-artifact@v4
with:
name: nextest-archive
name: nextest-archive-${{ matrix.os }}
- name: nextest partition ${{ matrix.partition }}/8
run: cargo nextest run --partition 'count:${{ matrix.partition }}/8' --archive-file 'nextest-archive.tar.zst' e2e
run: cargo nextest run --partition 'count:${{ matrix.partition }}/8' --archive-file 'nextest-archive-${{ matrix.platform.os }}.tar.zst' e2e

test-scarb-2-8-3:
name: Test scarb 2.8.3
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
@@ -188,7 +198,10 @@ jobs:

test-cast:
name: Test Cast
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@7b1c307e0dcbda6122208f10795a713336a9b35a
@@ -229,7 +242,10 @@ jobs:

test-scarb-api:
name: Test Scarb Api
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable