Remove needless sierra saving #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
ddoktorski
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Generally the change looks good, but it seems to break coverage as it currently relies on the Sierra path to get the project root so it would be necessary to address this first
|
@ksew1 is supposed to fix this |
|
@piotmag769 @ksew1 Please re-request review as related issue is resolved and tests are passing |
5 tasks
ksew1
added a commit
to software-mansion/cairo-coverage
that referenced
this pull request
Nov 18, 2024
) <!-- Reference any GitHub issues resolved by this PR --> Related foundry-rs/starknet-foundry#2637 ## Introduced changes <!-- A brief description of the changes --> - Allowed raw sierra to be in `target/dev` directory - Updated error messages ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
ksew1
approved these changes
Dec 12, 2024
cptartur
approved these changes
Dec 13, 2024
|
cc @ddoktorski |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2355
I was bored during a weekend, don't ask xD
Introduced changes
VersionedProgramout of the box.Checklist
CHANGELOG.md