Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat add exclude pattern running tests #2361

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feat add exclude pattern running tests #2361

wants to merge 5 commits into from
+97 −9

Conversation

julienbrs
Copy link

@julienbrs julienbrs commented Aug 9, 2024 •
edited
Loading

Closes #1512

Introduced changes

  • Added an --exclude flag that functions similarly to the existing FilterName. This flag allows users to exclude tests based on their names.
  • Note: The current filter functionality works without a specific flag (snforge test simple_test launches all tests beginning with "simple_test", rather than requiring snforge test --filter simple_test). Given this, I believe the new --exclude option might not be compatible with the existing filter option. What do you think?

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@julienbrs julienbrs marked this pull request as ready for review August 19, 2024 08:38
integraledelebesgue
integraledelebesgue requested changes Aug 21, 2024
View reviewed changes
crates/forge/src/run_tests/package.rs Outdated Show resolved Hide resolved
crates/forge/src/run_tests/test_target.rs Show resolved Hide resolved
crates/forge/src/run_tests/package.rs Outdated Show resolved Hide resolved
crates/forge/src/run_tests/package.rs Outdated Show resolved Hide resolved
@integraledelebesgue
Copy link
Member

Please fill the checklist and add your changes to the changelog :)

@integraledelebesgue
Copy link
Member

Also, always make sure to run cargo fmt and cargo lint before committing your changes

@julienbrs julienbrs requested a review from ddoktorski as a code owner August 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksew1 ksew1 Awaiting requested review from ksew1

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add exclusion of the tests in CLI
2 participants
@julienbrs @integraledelebesgue