Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make clippy happy #9601

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 29, 2024

all of the new literal_string_with_formatting_args warnings could be bogus and actually clippy bugs

warning: this looks like a formatting argument but it is not part of a formatting macro
  --> crates/forge/bin/cmd/generate/mod.rs:36:23
   |
36 |             .replace("{instance_name}", &instance_name);

for some reason clippy still emits

error: this looks like a formatting argument but it is not part of a formatting macro
 --> /home/runner/work/foundry/foundry/clippy.toml:2:15
  |
2 | # bytes::Bytes is included by default and alloy_primitives::Bytes is a wrapper around it,

which is coming from the clippy.toml

error: this looks like a formatting argument but it is not part of a formatting macro
--> /home/runner/work/foundry/foundry/clippy.toml:2:15
|
2 | # bytes::Bytes is included by default and alloy_primitives::Bytes is a wrapper around it,

@@ -140,6 +140,7 @@ pub fn eta_key(state: &indicatif::ProgressState, f: &mut dyn Write) {
write!(f, "{:.1}s", state.eta().as_secs_f64()).unwrap()
}

#[allow(clippy::literal_string_with_formatting_args)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you allow it globally and add todo linking to rust-lang/rust-clippy#13885

@mattsse mattsse requested a review from DaniPopes December 29, 2024 11:22
@mattsse mattsse enabled auto-merge (squash) December 29, 2024 11:28
@mattsse mattsse merged commit ffaa68f into foundry-rs:master Dec 29, 2024
22 checks passed
@grandizzy grandizzy added the L-ignore Log: ignore PR in changelog label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-ignore Log: ignore PR in changelog
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants