fix(config): support standalone symbolic section#15661
Open
mablr wants to merge 4 commits into
Open
Conversation
mablr
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mattsse and
stevencartavia
as code owners
figtracer
requested changes
Jul 9, 2026
mattsse
requested changes
Jul 11, 2026
mattsse
left a comment
mattsse
left a comment
Member
There was a problem hiding this comment.
The standalone happy path and warning coverage look good, but this currently changes behavior in two unsupported edge cases that need to be addressed before merging:
- In inherited configs,
[symbolic]and[profile.<name>.symbolic]converge only after the raw providers have been merged. This can make a base value override a local value and letsno-collisionmiss an effective collision: #15661 (comment) - Adding
symbolictoSTANDALONE_SECTIONSalso makes an unwrapped profile namedsymbolicbypass key normalization, so valid profile keys such aseth-rpc-urlcan be silently ignored: #15661 (comment)
Please separate standalone-section identity from selected-profile identity during normalization, and normalize standalone/profile-qualified symbolic entries to the same effective shape before applying inheritance precedence and collision detection. Regression coverage should include mixed inherited forms and FOUNDRY_PROFILE=symbolic.
Normalize standalone sections before inherited TOML sources are merged so equivalent profile-qualified values observe source precedence and no-collision checks. Apply profile key normalization before profile selection to preserve hyphenated keys when a profile shares a standalone section name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support top-level
[symbolic]config sections by treatingsymboliclike the existing standalonefuzzandinvariantsections during config normalization. This keeps[profile.<name>.symbolic]working as before while allowing shared symbolic defaults to be written as[symbolic], including env var normalization throughFOUNDRY_SYMBOLIC_*and section-aware unknown-key warnings.