Skip to content

Fix infinite loop in TAR extraction when encountering invalid file sizes #12543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Fix infinite loop in TAR extraction when encountering invalid file sizes #12543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions npm/src/install.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,13 @@ function extractFileFromTarball(tarballBuffer, filepath) {
8
)

const sizeInvalid = !Number.isFinite(fileSize) || Number.isNaN(fileSize) || fileSize < 0
if (sizeInvalid) {
const target = fileName === filepath ? filepath : fileName || '(unnamed entry)'
throw new Error(`Invalid size for ${target} in tarball`)
}

if (fileName === filepath) {
if (!Number.isFinite(fileSize) || Number.isNaN(fileSize) || fileSize < 0)
throw new Error(`Invalid size for ${filepath} in tarball`)
if (fileSize > MAX_BINARY_BYTES)
throw new Error(`Binary size for ${filepath} exceeds maximum allowed threshold`)
return tarballBuffer.subarray(offset, offset + fileSize)
Expand Down
Loading