feat: add support for 7594 blobs to anvil #12238
Open
+211
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
requested changes
Oct 22, 2025
Comment on lines
337
to
339
| // Convert BlobTransactionSidecarVariant to BlobTransactionSidecar for TxEnvelope | ||
| let converted_tx = match tx { | ||
| TxEip4844Variant::TxEip4844(tx) => TxEip4844Variant::TxEip4844(tx), |
There was a problem hiding this comment.
instead of converting, we should also update the return type here
which is
pub struct Transaction<T = TxEnvelope> {
Comment on lines
3307
to
3312
| let blobs = match &sidecar.sidecar { | ||
| BlobTransactionSidecarVariant::Eip4844(sidecar) => &sidecar.blobs, | ||
| BlobTransactionSidecarVariant::Eip7594(sidecar) => &sidecar.blobs, | ||
| }; | ||
| return Ok(Some(blobs.clone())); | ||
| } |
There was a problem hiding this comment.
could you upstream this as
fn blobs
and
fn into_blobs
Comment on lines
1064
to
1066
| Self::Legacy(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(), | ||
| Self::EIP2930(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(), | ||
| Self::EIP1559(tx) => TxEnvelope::from(tx.clone()).encode_2718_len(), |
There was a problem hiding this comment.
I think even those from calls here are redundant,
if you want, please submit this separately
mattsse
requested changes
Oct 24, 2025
Comment on lines
+35
to
+40
| pub trait BlobTransactionSidecarVariantExt { | ||
| /// Get a reference to the blobs | ||
| fn blobs(&self) -> &[alloy_consensus::Blob]; | ||
|
|
||
| /// Consume self and return the blobs | ||
| fn into_blobs(self) -> Vec<alloy_consensus::Blob>; |
There was a problem hiding this comment.
I meant adding this natively to alloy by sending a pr there :)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #12222
Solution
PR Checklist