fix(npm): robust fallback to dist binary in forge launcher #11859
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximevtush
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
|
We do not accept useless slop prs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the CLI uses the bundled dist binary when the platform package resolves but its binary file is missing, improving reliability on partially installed or corrupted environments.
Changes
getBinaryPath()to:dist/forge(orforge.exeon Windows) when the resolved path is missing.Why
require.resolve(...)can succeed while the actual file is missing (e.g., cache/corruption). Previously, the launcher didn’t use the fallback in this case, causing unnecessary failures.