Skip to content

fix(fmt): handle CRLF when needed #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(fmt): handle CRLF when needed #11843

wants to merge 1 commit into from
+5 −1

Conversation

0xrusowsky
Copy link
Contributor

@0xrusowsky 0xrusowsky commented Sep 26, 2025 •
edited by grandizzy
Loading

closes #11841

@0xrusowsky 0xrusowsky changed the base branch from master to rusowsky/11835 September 26, 2025 14:47
@grandizzy
Copy link
Collaborator

I suggest we should leave not formatted in such case and prevent panic in offset as a6d1e22

@grandizzy grandizzy mentioned this pull request Sep 28, 2025
Merged
4 tasks
Base automatically changed from rusowsky/11835 to master September 29, 2025 07:06
0xrusowsky
0xrusowsky commented Sep 29, 2025
View reviewed changes
Copy link
Contributor Author

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this only prevents the panic, but doesn't fix the underlying issue.

the output won't be properly formatted, as there won't be a line break with an offset, as what would happen with a unix compatible input file

@0xrusowsky 0xrusowsky closed this Sep 29, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy will be requested when the pull request is marked ready for review grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya will be requested when the pull request is marked ready for review yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(fmt): properly handle CRLF on windows files
2 participants
@0xrusowsky @grandizzy