fix(fs): flush BufWriter after GzEncoder::finish() in write_json_gzip_file #11827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In write_json_gzip_file, after GzEncoder::finish() we did not flush the inner BufWriter. Errors on the final buffered write can be silently ignored in Drop, causing undetected partial writes or I/O failures.
Why: BufWriter does not report errors on Drop. Without an explicit flush(), final write errors are lost. Additionally, we mapped finish() errors to WriteJson (serde) instead of I/O.
Fix: Capture the inner writer from finish() and call flush() on it. Map both finish() and flush() errors via FsPathError::write to provide correct path-contextual I/O errors.
Context: This gzip-to-disk path is only used by evm::executors::corpus when corpus_gzip is enabled. Other gzip usage (anvil state dump) targets Vec and doesn’t require flush(). Non-gzip JSON writers already call flush() explicitly.