feat(config): warn on unknown config keys in foundry.toml #11816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning::UnknownKey and Display\n- Collect unknown top-level keys in active profile via WarningsProvider\n- Ignore casing-only differences (kebab/snake)\n- Add unit test for unknown key warning\n\nRefs: foundry-rs#10550, inspired by foundry-rs#10621
TropicalDog17
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
grandizzy
previously approved these changes
Sep 29, 2025
There was a problem hiding this comment.
thank you, looks good! made minor change to apply for all profiles and test, @DaniPopes pls check if this approach without serde-ignored also OK, thanks
grandizzy
approved these changes
Sep 29, 2025
DaniPopes
approved these changes
Sep 30, 2025
onbjerg
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #10550
Solution
PR Checklist