fix: use sourcify for selector lookups #11757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks and
0xrusowsky
as code owners
onbjerg
force-pushed
the
onbjerg/sourcify
branch
from
0aaa03f to
2e229b0
Compare
DaniPopes
previously approved these changes
Sep 22, 2025
etc. |
|
This is also blocked by the fact that there is no selector upload 👍 |
kathleenmotley49-maker
approved these changes
Sep 23, 2025
onbjerg
force-pushed
the
onbjerg/sourcify
branch
5 times, most recently
from
7755e98 to
c781086
Compare
kathleenmotley49-maker
approved these changes
Sep 30, 2025
onbjerg
force-pushed
the
onbjerg/sourcify
branch
2 times, most recently
from
5c84701 to
3bb479f
Compare
kathleenmotley49-maker
approved these changes
Sep 30, 2025
kathleenmotley49-maker
approved these changes
Sep 30, 2025
onbjerg
force-pushed
the
onbjerg/sourcify
branch
3 times, most recently
from
200e1af to
e0e4ebc
Compare
onbjerg
force-pushed
the
onbjerg/sourcify
branch
5 times, most recently
from
5d45365 to
f160f96
Compare
DaniPopes
reviewed
Sep 30, 2025
onbjerg
force-pushed
the
onbjerg/sourcify
branch
4 times, most recently
from
5389b8a to
8fa2472
Compare
onbjerg
force-pushed
the
onbjerg/sourcify
branch
from
8fa2472 to
61fa3cb
Compare
onbjerg
force-pushed
the
onbjerg/sourcify
branch
from
61fa3cb to
797a277
Compare
0xrusowsky
reviewed
Sep 30, 2025
| casttest!(fourbyte, |_prj, cmd| { | ||
| cmd.args(["4byte", "0xa9059cbb"]).assert_success().stdout_eq(str
There was a problem hiding this comment.
is this the other fn sig that produces a selector collision that u mentioned earlier?
should we add a small cmnt or is it clear enough already?
There was a problem hiding this comment.
yes and idt a comment makes sense, we just have to live with the fact that people can find collissions and break our test suite 😢
DaniPopes
approved these changes
Sep 30, 2025
grandizzy
added a commit
to grandizzy/foundry
that referenced
this pull request
Oct 1, 2025
This reverts commit e9764bb.
grandizzy
added a commit
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Openchain has been transferred to Sourcify, and the original domain was not migrated.
Solution
Use the new Sourcify API for selector lookup and import.
I've removed some duplicate tests, and some tests that no longer apply. Additionally, I've had to ignore some tests because they depend on selectors that are not present in Sourcify.
PR Checklist