fix(script): prevent --verify without --broadcast from causing deployment not found error #11734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeVikingMark
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
onbjerg
requested changes
Sep 20, 2025
crates/script/src/lib.rs
Outdated
Comment on lines
252
to
256
| if compiled.args.verify && !compiled.args.should_broadcast() { | ||
| eyre::bail!( | ||
| "The --verify flag requires --broadcast to be specified. Verification without broadcasting is not meaningful." | ||
| ); | ||
| } |
There was a problem hiding this comment.
you can do this with requires on verify: https://docs.rs/clap/latest/clap/struct.Arg.html#method.requires
onbjerg
requested changes
Sep 23, 2025
This was referenced Oct 2, 2025
|
Ping @DeVikingMark, some of the tests are failing because the help output of |
onbjerg
requested changes
Oct 9, 2025
crates/forge/tests/cli/script.rs
Outdated
Comment on lines
3255
to
3269
| [..] → new Counter@0x5FbDB2315678afecb367f032d93F642f64180aa3 | ||
| [96345] → new Counter@0x5FbDB2315678afecb367f032d93F642f64180aa3 | ||
| └─ ← [Return] 481 bytes of code | ||
| [..] Counter::increment() | ||
| [22418] Counter::increment() |
There was a problem hiding this comment.
please change this to dots again (the gas usage isn't relevant):)
onbjerg
approved these changes
Oct 14, 2025
|
tests are still failing ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
forge script --verifywithout--broadcastfails with "Deployment not found for chain" error because it tries to load non-existent deployment files.Solution
--verifyis used without--broadcast--broadcastwhen using--verifyChanges
crates/script/src/lib.rs: Fix logic and add validationcrates/forge/tests/cli/script.rs: Add test caseFixes #11726