Skip to content

fix(forge): vm.getChain use config for rpc and alias #10806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

fix(forge): vm.getChain use config for rpc and alias #10806

merged 1 commit into from
Jun 19, 2025
+27 −13

Conversation

grandizzy
Copy link
Collaborator

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review June 19, 2025 05:52
@grandizzy grandizzy enabled auto-merge (squash) June 19, 2025 05:52
mattsse
mattsse approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, makes sense

@grandizzy grandizzy merged commit 23e8841 into foundry-rs:master Jun 19, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Jun 19, 2025
@grandizzy grandizzy deleted the issue-10801 branch June 19, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vm.getChain(block.chainid).chainAlias returns chain id
2 participants
@grandizzy @mattsse