chore: remove unused code #10718
Closed
chore: remove unused code #10718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Jun 5, 2025
Comment on lines
-2422
to
-2429
| /// Sets the reported block number | ||
| /// | ||
| /// Handler for ETH RPC call: `anvil_setBlock` | ||
| pub fn anvil_set_block(&self, block_number: u64) -> Result<()> { | ||
| node_info!("anvil_setBlock"); | ||
| self.backend.set_block_number(block_number); | ||
| Ok(()) | ||
| } |
Member
Author
There was a problem hiding this comment.
This should probably be implemented instead of removed
zerosnacks
commented
Jun 5, 2025
Comment on lines
-570
to
-600
| /// Returns protocol version encoded as a string (quotes are necessary). | ||
| /// | ||
| /// Handler for ETH RPC call: `eth_protocolVersion` | ||
| pub fn protocol_version(&self) -> Result<u64> { | ||
| node_info!("eth_protocolVersion"); | ||
| Ok(1) | ||
| } | ||
|
|
||
| /// Returns the number of hashes per second that the node is mining with. | ||
| /// | ||
| /// Handler for ETH RPC call: `eth_hashrate` | ||
| pub fn hashrate(&self) -> Result<U256> { | ||
| node_info!("eth_hashrate"); | ||
| Ok(U256::ZERO) | ||
| } | ||
|
|
||
| /// Returns the client coinbase address. | ||
| /// | ||
| /// Handler for ETH RPC call: `eth_coinbase` | ||
| pub fn author(&self) -> Result<Address> { | ||
| node_info!("eth_coinbase"); | ||
| Ok(self.backend.coinbase()) | ||
| } | ||
|
|
||
| /// Returns true if client is actively mining new blocks. | ||
| /// | ||
| /// Handler for ETH RPC call: `eth_mining` | ||
| pub fn is_mining(&self) -> Result<bool> { | ||
| node_info!("eth_mining"); | ||
| Ok(self.is_mining) | ||
| } |
Member
Author
There was a problem hiding this comment.
these should likely be implemented, they are currently not
zerosnacks
commented
Jun 5, 2025
Comment on lines
-325
to
-327
| // Helper function to set default chains | ||
| fn create_default_chains() -> HashMap<String, ChainData> { | ||
| let mut chains = HashMap::new(); |
Member
Author
There was a problem hiding this comment.
This is entirely unused / not wired up, I think these are leftover files from #10226
DaniPopes
reviewed
Jun 5, 2025
mattsse
reviewed
Jun 26, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
can we do this incrementally,
reviewing a large cleanup like this isnt really feasible
Member
Author
|
closing, will do selectively changes as separate PRs in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Opening for visibility + discussion
Solution
Methodology: https://gist.github.com/zerosnacks/227ac62697fba3c868db4156d4e37610
Removes unused code
PR Checklist