This repository was archived by the owner on Apr 20, 2026. It is now read-only.
fix(mock): use num_sources in populate for source file count#322
Closed
Snezhkko wants to merge 1 commit intofoundry-rs:mainfrom
Closed
fix(mock): use num_sources in populate for source file count#322Snezhkko wants to merge 1 commit intofoundry-rs:mainfrom
Snezhkko wants to merge 1 commit intofoundry-rs:mainfrom
Conversation
Snezhkko
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MockProjectGenerator::populate method incorrectly used settings.num_lib_files when adding source files, effectively ignoring settings.num_sources. This change aligns the code with the documented intent: num_sources controls the number of source files, while num_lib_files controls the number of files per library. This prevents silent misconfiguration and matches the semantics used elsewhere in the API and tests.