Add v2 verify routes #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jan 11, 2025
|
@mattsse updated with suggestions |
mattsse
requested changes
Jan 22, 2025
| @@ -99,6 +115,16 @@ impl Client { | |||
| Client::builder().with_api_key(api_key).chain(chain)?.build() | |||
| } | |||
|
|
|||
| /// Create a new client with the correct endpoint with the chain and chosen API v2 version | |||
| pub fn new_v2_from_env(chain: Chain) -> Result<Self> { | |||
There was a problem hiding this comment.
I think we also want a way to set the version, like
fn with_version(self, v) -> Self
There was a problem hiding this comment.
This already exists:
/// Configures the etherscan api version
pub fn with_api_version(mut self, api_version: EtherscanApiVersion) -> Self {
self.etherscan_api_version = api_version;
self
}
Comment on lines
+120
to
+125
| let api_key = std::env::var("ETHERSCAN_API_KEY")?; | ||
| Client::builder() | ||
| .with_api_version(EtherscanApiVersion::V2) | ||
| .with_api_key(api_key) | ||
| .chain(chain)? | ||
| .build() |
There was a problem hiding this comment.
then this can just call new ad with_version(v2)
There was a problem hiding this comment.
A little confused as to where this would be called -- within the builder or skip the builder entirely and use with_version() rather than new_v2_from_env?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard-json-inputintegration testsThis is a prerequisite PR for foundry-rs/foundry#9196
Notes: