Skip to content

Commit

Permalink
[php82] fix _stop function
Browse files Browse the repository at this point in the history
  • Loading branch information
beinbm committed Aug 11, 2023
1 parent 5c58bb1 commit 8d6d37a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/Cake/Console/ShellDispatcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ public function help()
* @param int|string $status see http://php.net/exit for values
* @return void
*/
protected function _stop($status = 0): never
protected function _stop($status = 0): void
{
exit($status);
}
Expand Down
1 change: 0 additions & 1 deletion lib/Cake/Core/CakeObject.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ public function dispatchMethod($method, $params = [])
* testing easier.
*
* @param int|string $status see http://php.net/exit for values
* @return void
*/
protected function _stop($status = 0): never
{
Expand Down
5 changes: 1 addition & 4 deletions lib/Cake/Test/Case/Console/ShellDispatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,9 @@ public function clear() {

/**
* _stop method
*
* @return void
*/
protected function _stop($status = 0) {
protected function _stop($status = 0): void {
$this->stopped = 'Stopped with status: ' . $status;
return $status;
}

/**
Expand Down
1 change: 1 addition & 0 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

$rectorConfig->parallel(360, 8);

$rectorConfig->phpVersion(PhpVersion::PHP_80);
// DEFINE RULES (Single & Sets)
// Rule Overview: https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md
// Register a single rule
Expand Down

0 comments on commit 8d6d37a

Please sign in to comment.