Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Run under bubblewrap" after forking #492

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

reshi-reshlet
Copy link

@reshi-reshlet reshi-reshlet commented Jan 2, 2025

Fix "Run under bubblewrap" after forking

"Run under bubblewrap" was failing after I forked the repo.
Here is what I did to fix it.

  1. New Flex Mirror Links
    The original mirrors for flex-2.5.11 and flex-2.5.33 appear to be down.
    I replaced them with:

    • http://ftp-tel.sjtu.edu.cn/sites/ftp.openpkg.org/sources/DST/flex/flex-2.5.11.tar.gz
    • http://ftp-tel.sjtu.edu.cn/sites/ftp.openpkg.org/sources/DST/flex/flex-2.5.33.tar.gz

    The original mirror (http://download.nust.na/pub2/openpkg1) has been unreliable in the past.
    See:

  2. Ubuntu Version Check
    GitHub ran the workflow on Ubuntu 22.04.5 LTS,
    despite bwrap.yaml specifying runs-on: ubuntu-latest.
    This made the build fail when trying to do the AppArmor workaround.

    • See the failing build.
      you can see the ubuntu version in the "set up job" section.
    • Added a script to check the Ubuntu version,
      and apply the AppArmor workaround only if the version is >= 24.04.
  3. Added Version Check Script to Lint Workflow
    New script clearing ShellCheck:

  4. Successful Workflow Execution
    "Run under bubblewrap" working in my fork:

deal with github mysteriously running actions with "ubuntu-latest" not resolving to 24.04. check for current ubuntu version and only do bwrap fix it >= 24.04

also, patch flakey flex mirrors, which were not working
shellcheck new script in linter workflow
@fosslinux
Copy link
Owner

I'm not entirely sure this is the right way to go about it. I'd rather prefer that we change ubuntu-latest to ubuntu-24.04.

@reshi-reshlet
Copy link
Author

Switching to ubuntu-24.04 would work. Seems nicer to have explicit deps anyway.
Thought I would whip up the 'version agnostic' fix, in case that would be preferred.

@fosslinux do you want me to adjust my branch? I am not the most familiar with doing pull requests, so if I was going to do this, I would maybe just make a new branch and submit a new PR (and close this one).

@fosslinux
Copy link
Owner

Yeah, you can do that, or otherwise the "usual" way of doing it would be to make the changes on this branch and just push the changes. But you can make a new PR if you would like.

avoid the complicated version detection
@reshi-reshlet
Copy link
Author

updated the branch: got rid of the version detection, and just switched to ubuntu-24.04

CI build started here (hasn't finished yet, but I expect it to 'work')
https://github.com/reshi-reshlet/live-bootstrap/actions/runs/12637879733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants