-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Run under bubblewrap" after forking #492
base: master
Are you sure you want to change the base?
Conversation
deal with github mysteriously running actions with "ubuntu-latest" not resolving to 24.04. check for current ubuntu version and only do bwrap fix it >= 24.04 also, patch flakey flex mirrors, which were not working
add shebang
shellcheck new script in linter workflow
I'm not entirely sure this is the right way to go about it. I'd rather prefer that we change |
Switching to ubuntu-24.04 would work. Seems nicer to have explicit deps anyway. @fosslinux do you want me to adjust my branch? I am not the most familiar with doing pull requests, so if I was going to do this, I would maybe just make a new branch and submit a new PR (and close this one). |
Yeah, you can do that, or otherwise the "usual" way of doing it would be to make the changes on this branch and just push the changes. But you can make a new PR if you would like. |
avoid the complicated version detection
updated the branch: got rid of the version detection, and just switched to ubuntu-24.04 CI build started here (hasn't finished yet, but I expect it to 'work') |
Fix "Run under bubblewrap" after forking
"Run under bubblewrap" was failing after I forked the repo.
Here is what I did to fix it.
New Flex Mirror Links
The original mirrors for
flex-2.5.11
andflex-2.5.33
appear to be down.I replaced them with:
http://ftp-tel.sjtu.edu.cn/sites/ftp.openpkg.org/sources/DST/flex/flex-2.5.11.tar.gz
http://ftp-tel.sjtu.edu.cn/sites/ftp.openpkg.org/sources/DST/flex/flex-2.5.33.tar.gz
The original mirror (
http://download.nust.na/pub2/openpkg1
) has been unreliable in the past.See:
(search for "flex-2.5.11.tar.gz can't be download")
Ubuntu Version Check
GitHub ran the workflow on Ubuntu 22.04.5 LTS,
despite
bwrap.yaml
specifyingruns-on: ubuntu-latest
.This made the build fail when trying to do the AppArmor workaround.
you can see the ubuntu version in the "set up job" section.
and apply the AppArmor workaround only if the version is
>= 24.04
.Added Version Check Script to
Lint
WorkflowNew script clearing ShellCheck:
Successful Workflow Execution
"Run under bubblewrap" working in my fork: