Musl fixes #490
Open
Musl fixes #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since an old patch version, it has (for reasonable security reasons) not supported patched with ../ in the filename. Many of our patches have been relying on this behaviour being OK, because we start off with an ancient patch version that didn't perform such checks. As soon as we need this behaviour after we build a newer patch though, we will have problems. So, let's change the policy. Patches are relative to where tarballs are extracted, rather than the "working directory" - e.g. have patches for `coreutils-9.4/src/cp.c` instead of `src/cp.c`. Keeping this consistent has a few implications; - patches are applied from the build/ directory in bash era now, with `-p0` - when patches are manually applied in the bash era, use `-p` as required, usually `-p1` - in kaem era where patches are always manually applied, `-p1` is used
Some pregenerated header files exist in the src/ctype and src/locale directories. They are generated by out-of-tree code found on GitHub, musl-chartable-tools. This causes a slight reordering of the early bootstrap, as the early environment is quite spartan and has broken/missing tools to regenerate these files. With an added rebuild everything works fine.
fosslinux
force-pushed
the
musl-fixup
branch
from
22ddeb1 to
1cdb2fe
Compare
fosslinux
commented
Dec 23, 2024
There was a problem hiding this comment.
FWIW, I am not entirely happy with the licensing state of musl-chartable-tools.
richfelker/musl-chartable-tools#3 strongly implies to me that the author intends for it to be MIT licensed, yet there is a second contributor and no license in the repository.
Should we contact the author? Thoughts?
Yes, they should either add a license to the repository or at least the 2nd author should clarify... |
stikonas
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #489