-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive "configurator" #468
Conversation
Did you test if this actually works with kernel bootstrap? At that point, we're still running on builder-hex0, which may not support keyboard input. |
If possible, I would like to see this split out into it's own option. This would allow both an interactive editor and a scripted build that can end in an interactive environment. |
I'm a fair bit more happy with the state of this now. It works under builder-hex0, at a later stage, and doesn't run if you do use rootfs.py to generate a complete bootstrap.cfg file. There is a separate variable toggling use of configurator. I believe that perhaps this may have pushed Fiwix over the ramdisk size as far as I can tell, but retesting that now. Planning to do a little bit more testing but would appreciate re-reviews at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, thanks.
if (kernel->sysname == NULL) { | ||
no_input(head); | ||
return 0; | ||
} else if (strcmp(kernel->sysname, "Linux") != 0 && strcmp(kernel->sysname, "Fiwix") != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a more future-proof way of detecting builder-hex0, that won't come back to bite us when we try to bootstrap on e.g. Hurd or macOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked briefly for any key features of builder-hex0 that make it detectable, but it appears to be fairly silent on its existence - which kind of is a good thing I guess!
Either way, we'll have to modify the checks at some point; either for stage0-uefi, or for other kernels live-bootstrap can be run on.
There isn't really any reason to use gzip instead of bzip2 for the Linux initramfs/kernel, since we have it! Saves a few MB (~13MB as far as I can tell)
We need just a couple more MB for configurator to be added! The tolerances are *very* tight now...
This is a more UX-friendly glorified bootstrap.cfg editor. Somewhat inspired by kconfig.
This is a more UX-friendly glorified bootstrap.cfg editor. Somewhat inspired by kconfig.
Mostly complete, but WIP still
Known bugs:
validation of string inputs does not currently workDepends on oriansj/M2libc#