Fix early-preseed (and environment variables generally)#467
Merged
Googulator merged 1 commit intomasterfrom May 10, 2024
Merged
Fix early-preseed (and environment variables generally)#467Googulator merged 1 commit intomasterfrom
Googulator merged 1 commit intomasterfrom
Conversation
stikonas
approved these changes
May 10, 2024
Googulator
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a small environmental discrepancy between
--early-preseedmode and normal mode which causes a build failure when--early-preseedis used.Namely, bash reads any environment variables that are already in the the environment. In
--early-preseedmode there are none of these, whereas there are a number when bash is called from normal mode as a result of kaem setting those environment variables.This causes variables such as
LIBDIRto beexported by default in kaem mode but not in--early-preseedmode. We can work around this by unsetting them and resetting them inupdate_env.sh.