Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bubblewrap support & CI workflows after simplify #361

Merged
merged 13 commits into from
Dec 26, 2023

Conversation

Googulator
Copy link
Collaborator

@Googulator Googulator commented Dec 23, 2023

Depends on #354 and #366

@Googulator
Copy link
Collaborator Author

Seems like there are more checksum changes, and I don't currently understand why. I'll need to investigate this further.

@Googulator
Copy link
Collaborator Author

Googulator commented Dec 25, 2023

The checksum changes are now resolved:

For some reason, source caching isn't working, but that's only a performance issue, without affecting correctness of the tests or the bootstrap.

@Googulator Googulator force-pushed the fix-bwrap branch 5 times, most recently from 5f50c2a to b7fb5c6 Compare December 25, 2023 16:40
@Googulator
Copy link
Collaborator Author

Source caching is now solved.

These are implemented as dummy jumps with a script that just exits
with success. Since this script will be sourced, rather than called,
this causes the bootstrap process to exit at that point.
The breakpoints are conditional on INTERNAL_CI (we check for "pass1"
because that's the only pass when script-generator runs, but the
resulting effect is that each pass only bootstraps its own part of
the manifest).
Not that it's exactly copyrightable, being just "exit 0", but linter complains about it.
This makes bwrap work on Debian 10.
Fixes pass3 prematurely reporting success and quitting, having built nothing.
@fosslinux fosslinux merged commit 81790a3 into fosslinux:master Dec 26, 2023
4 checks passed
@Googulator Googulator deleted the fix-bwrap branch December 28, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants