-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bubblewrap support & CI workflows after simplify #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like there are more checksum changes, and I don't currently understand why. I'll need to investigate this further. |
The checksum changes are now resolved:
For some reason, source caching isn't working, but that's only a performance issue, without affecting correctness of the tests or the bootstrap. |
Googulator
force-pushed
the
fix-bwrap
branch
5 times, most recently
from
December 25, 2023 16:40
5f50c2a
to
b7fb5c6
Compare
Source caching is now solved. |
This was referenced Dec 25, 2023
These are implemented as dummy jumps with a script that just exits with success. Since this script will be sourced, rather than called, this causes the bootstrap process to exit at that point. The breakpoints are conditional on INTERNAL_CI (we check for "pass1" because that's the only pass when script-generator runs, but the resulting effect is that each pass only bootstraps its own part of the manifest).
Not that it's exactly copyrightable, being just "exit 0", but linter complains about it.
This makes bwrap work on Debian 10.
Fixes pass3 prematurely reporting success and quitting, having built nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #354 and #366