Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 2.5.6 for parallel pgen invocation #325

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

nanonyme
Copy link
Contributor

@nanonyme nanonyme commented Nov 6, 2023

@nanonyme
Copy link
Contributor Author

nanonyme commented Nov 6, 2023

@fosslinux looks like build is failing as part of pkg-config removal. I'm running a pipelien on our side at https://gitlab.com/freedesktop-sdk/freedesktop-sdk-binary-seed/-/jobs/5467602634

@nanonyme
Copy link
Contributor Author

nanonyme commented Nov 6, 2023

We are mirroring our sources so the removal doesn't really impact us. We are using method for obtaining sources where we prefetch them with manifest since we anyway do not actually boot a system but run something similar to Bubblewrap.

@nanonyme nanonyme marked this pull request as draft November 6, 2023 22:06
@nanonyme
Copy link
Contributor Author

nanonyme commented Nov 6, 2023

Unfortunately it looks like this patch changes hashes. I will need to find out if they are changed in a reproducible way.

@fosslinux
Copy link
Owner

Yes, the pkg-config thing is expected to fail builds at the moment.

Many things can change hashes, I'm not particularly concerned that hashes are changed - just that the new hash is always the same :)

@nanonyme
Copy link
Contributor Author

nanonyme commented Nov 6, 2023

Does the pkg-config situation effectively mean nothing can be merged for the time being?

@fosslinux
Copy link
Owner

The CI should still pass, because it's using download-distfiles.sh (external distfiles)...

Things can still be merged.

@nanonyme
Copy link
Contributor Author

nanonyme commented Nov 7, 2023

This CI ironically would most likely be considerably faster with parallel build on.

@nanonyme nanonyme marked this pull request as ready for review November 7, 2023 15:32
@nanonyme
Copy link
Contributor Author

nanonyme commented Nov 7, 2023

@fosslinux it seems this new hash reproduced multiple times so I'm hopeful that it persists. I suspect there is one extra file (the timestamp file) as a result of the patch.

@fosslinux
Copy link
Owner

Copy link
Owner

@fosslinux fosslinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fosslinux fosslinux merged commit 7747e86 into fosslinux:master Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 2.5 build failures with parallel build on
2 participants