-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 2.5.6 for parallel pgen invocation #325
Conversation
@fosslinux looks like build is failing as part of pkg-config removal. I'm running a pipelien on our side at https://gitlab.com/freedesktop-sdk/freedesktop-sdk-binary-seed/-/jobs/5467602634 |
We are mirroring our sources so the removal doesn't really impact us. We are using method for obtaining sources where we prefetch them with manifest since we anyway do not actually boot a system but run something similar to Bubblewrap. |
Unfortunately it looks like this patch changes hashes. I will need to find out if they are changed in a reproducible way. |
Yes, the pkg-config thing is expected to fail builds at the moment. Many things can change hashes, I'm not particularly concerned that hashes are changed - just that the new hash is always the same :) |
Does the pkg-config situation effectively mean nothing can be merged for the time being? |
The CI should still pass, because it's using download-distfiles.sh (external distfiles)... Things can still be merged. |
This CI ironically would most likely be considerably faster with parallel build on. |
@fosslinux it seems this new hash reproduced multiple times so I'm hopeful that it persists. I suspect there is one extra file (the timestamp file) as a result of the patch. |
The CI already runs with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backported from https://github.com/python/cpython/commit/9828b56347f6171a532dce28c9dc5ab9bd2c8139.patch
Fixes #321