-
Notifications
You must be signed in to change notification settings - Fork 82
[Feature] new UI #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] new UI #83
Conversation
Signed-off-by: Vedansh Saini <[email protected]>
…ay selector not working Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
Reviewer's GuideThis pull request implements a new standalone popup UI for the Scrum Helper extension, featuring a modern design with Tailwind CSS, improved report generation (including a new 'yesterday' option), enhanced error handling, and a more flexible architecture for generating and copying scrum reports. The build system is updated to support Tailwind CSS, and several legacy UI and logic elements are refactored or removed. Class Diagram: Script Modifications for New Popup UIclassDiagram
class scrumHelperJs {
<<Module>>
-yesterday: Boolean
-outputTarget: String
+allIncluded(outputTarget String) void "Modified: Added outputTarget, yesterday logic. Removed gsoc logic."
+fetchGithubData() void "Modified: Improved error logging, direct calls to writers"
+writeGithubIssuesPrs() void "Modified: Clears arrays before processing"
+writeGithubPrsReviews() void "Modified: Clears arrays, fixed variable name"
+getYesterday() String "New function"
+handleYesterdayChange() void "New function"
+getLastWeek() String "Modified: Removed gsoc dependency"
+formatDate(dateString String) String
+getProject() String
+scrumSubjectLoaded() void "Modified: Removed gsoc logic"
+window_generateScrumReport() void "New global function for popup integration"
note for scrumHelperJs "gsoc variable and related logic removed."
}
class popupJs {
<<New Script>>
-generateReportButton: DOMElement
-copyReportButton: DOMElement
-scrumReportDiv: DOMElement
-darkModeToggle: DOMElement
+handleGenerateReportClick() void
+handleCopyReportClick() void
+toggleRadio(radioElement DOMElement) void
+initializeEventListeners() void
+getToday() String
+getYesterday() String
+getLastWeek() String
}
class mainJs {
<<Script>>
-handleGsocClick() void "Removed function"
-handleCodeheatClick() void "Removed function"
}
popupJs ..> scrumHelperJs : calls window_generateScrumReport
scrumHelperJs ..> mainJs : (indirectly, main.js sets up initial calls/listeners that might use scrumHelper.js, but main.js itself is simplified)
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This PR has correct fetch logic but lacks some basic and some important tweaks. |
Signed-off-by: Vedansh Saini <[email protected]>
Fine tuned ui. |
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
In these latest changes I have added a toggleRadio function and fixed the enable disable toggle. |
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
In the latest changes I fixed the toggleRadio functionality and improved the enable disable toggle. |
Signed-off-by: Vedansh Saini <[email protected]>
In this commit I have added dark mode and improved visuals. |
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
In the latest commits, I have enhanced the buttons and their behavior, I fixed the bug of standalone report in which the date was not being updated in the generate scrum function, i.e. the report for custom dates was not getting generated. |
@hongquan I have done a lot in this draft pr, and a lot needs to be done, I'll move onto performance optimization and writing tests, in the meanwhile I'd truly appreciate if you could take a look at this and then maybe we can discuss additional sorting parameters for the data. |
Signed-off-by: Vedansh Saini <[email protected]>
In the last commit I added a smoother dark mode transition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@mariobehling @hongquan This UI might have some bugs, I am working on finding and fixing them, but I'd need your approval to know whether I'm moving in the right direction or not. |
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
Also change replace the last question What is stopping you from doing your work with "What is blocking you from making progress?" |
Signed-off-by: Vedansh Saini <[email protected]>
Please make the following changes: Notes:
@vedansh-5 to confirm: based on note 1, someone reviewed a PR 10 days ago, it will still show in his/her last 7 days activity? Also please unbold the top description. |
|
Yes, if the pr has been updated it will show in last 7 days |
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
@vedansh-5 When I select the last 1 day, the content/heading questions still show last 7 days @Preeti9764 please also help to test this, let's aim to release it today |
Thanks for pointing it out, I am aware of this, I'll fix it and push the code along with working standalone. |
okay ,let me check this out. |
yes, it is showing last week for yesterday , and also there is issue with scrum report generation when i switched to 1 day and then back again to 7 days . I would suggest to look at the functionality of last 7 days button cause it is not working. |
Fixed the radios. Will now work on the standalone scrum generation. In the meantime @Preeti9764 could you take a look #94 for the new rebase errors. Thanks |
@hpdang This PR is ready to be merged with all the functionalities, please take a look whenever you can. |
@vedansh-5 very nice! Could you please also change the blocker question and the Notes part?
Notes:
|
sorry to have missed it, I'll do it right away. |
@hpdang I have made the requested changes. Please take a look. Thanks |
This should apply in the Email content too. Thank you! |
I have tested the new UI and it is all good and ready to be merged . Thanks! |
@Preeti9764 did you also test in Yahoo and Outlook? Thanks |
yes,I tested on all the plateforms |
@hpdang in my case it is showing correct...this is gmail draft. |
Closes #67
stand alone popup UI
Summary by Sourcery
Redesign the popup UI with a modern layout using Tailwind CSS, add dark mode support, and enhance the scrum report generation and copy functionality. Remove legacy GSoC/CodeHeat logic and refactor scrum data handling for improved flexibility and user experience.
Enhancements:
Build:
Documentation: