-
Notifications
You must be signed in to change notification settings - Fork 79
UI extension, standalone scrum report #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a standalone scrum report feature with live preview, GitHub data fetching, and Markdown link conversion. It enhances the user experience by providing a WYSIWYG preview and ensuring the copied text is in a format suitable for platforms that support Markdown. The pull request also includes improvements to GitHub data fetching and updates the README with new feature descriptions. Sequence diagram for generating scrum report in popupsequenceDiagram
participant User
participant Popup
participant Extension
participant GitHub API
User->>Popup: Opens popup
User->>Popup: Enters GitHub username
User->>Popup: Clicks 'Generate Report'
Popup->>Extension: Calls generateScrumReport()
Extension->>Extension: allIncluded('popup')
Extension->>GitHub API: Fetches issues and PRs
GitHub API-->>Extension: Returns data
Extension->>Extension: Processes data and generates HTML report
Extension->>Popup: Updates scrumReport div with HTML content
Popup->>User: Displays report preview
Sequence diagram for copying scrum report to clipboardsequenceDiagram
participant User
participant Popup
participant Extension
User->>Popup: Clicks 'Copy Report'
Popup->>Extension: Handles copyReport()
Extension->>Extension: Converts HTML links to Markdown
Extension->>Extension: Removes state buttons
Extension->>Extension: Replaces <br> with \n
Extension->>Extension: Adds '- ' to list items
Extension->>Extension: Removes <ul> tags
Extension->>Extension: Trims whitespace
Extension->>Extension: Copies Markdown to clipboard
Extension->>Popup: Displays success message
Popup->>User: Report copied to clipboard
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a more robust error handling strategy for the GitHub API requests, perhaps with retry logic or more informative user feedback.
- The logic for converting HTML to Markdown could be improved to handle more complex HTML structures.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review on actual code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider creating a separate function to handle the GitHub API calls to improve readability.
- The logic for generating the scrum report is quite complex; consider breaking it down into smaller, more manageable functions.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@hongquan, I’d really appreciate your feedback on these changes. Also, is there any other platform besides Glitter where I can discuss functionalities and any obstacles I encounter? |
@hongquan Follow up on this PR, please have a look whenever you have some free time. Thanks. |
@vedansh-5 the generated report looks very good! I tested it on the Gmail tab, but the content in the report and my Gmail draft don’t match. Do you know why? |
Thanks for pointing that out! That's new to me, I'll skim through the code and see what might be causing the mismatch between the report and the Gmail draft. I’ll let you know what I find. |
Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
…ments, refined fetching logic Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
functions Signed-off-by: Vedansh Saini <[email protected]>
updated readme Signed off-by: Vedansh Saini <[email protected]>
…ed comments, rebased Signed-off-by: Vedansh Saini <[email protected]>
@hpdang I could not reproduce the error of unmatched content but I did some potential fixes. Could you check if the bug persists or not? Thanks! |
Signed-off-by: Vedansh Saini <[email protected]>
The problem only occurs when I uncheck the box for “Show past 1 day from today.” The issue was there when I defined a custom date range, the generated report content does not match the gmail prefilled data Additionally, I’ve observed some unexpected behavior when using the extension on the Gmail tab:
Does it mean the popup and Gmail draft prefill may be running independently, and can't work together in real-time without a reload? These issue were not there in the approach of PR 79 @Preeti9764 could you please test this PR and confirm whether you face similar issues? |
Thank you for pointing this out, @hpdang . I’ll look into this and test the PR to verify the behavior. I’ll share my observations shortly. |
@Preeti9764 I tested again with the recent push, popup and gmail prefill can run now together but the unmatched issue is still there |
Thanks for testing it again, @hpdang . I'm glad to hear the popup and Gmail prefill now work together. I'll investigate the remaining mismatch issue between the standalone preview and the Gmail content and work on aligning them correctly. |
@Preeti9764 Are you facing the same issues? |
@vedansh-5 please resolve conflicts |
Resolved the conflicts, good to merge! |
Standalone Scrum Report with Markdown Link Support
Description
This PR implements a standalone scrum report section as part of the GSoC problem statement. The key features include:
[Title](link)
Testing
The feature can be tested by:
This enhancement improves the user experience by providing a WYSIWYG preview while ensuring the copied text is in a format suitable for platforms that support Markdown.
readme.md is also updated listing the new features.
scrumhelper.standalone.mp4
Summary by Sourcery
Implement a standalone scrum report feature in the browser extension with enhanced reporting capabilities, including live preview, GitHub data fetching, and Markdown link conversion.
New Features:
Enhancements:
Documentation:
Tests: