Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swahili language #285

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

hongquan
Copy link
Member

@hongquan hongquan commented Feb 26, 2025

Fixes #265.

This PR include update of PO files from other languages because those files have not been updated after changes in previous PRs.

How has this been tested?

image

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Adds support for the Swahili language to the application by including it in the available language options.

Copy link

sourcery-ai bot commented Feb 26, 2025

Reviewer's Guide by Sourcery

This pull request adds support for the Swahili language to the application. It includes changes to the settings file to register the new language and adds an empty django.po file for translations. Additionally, it updates multiple django.po files and the django.pot file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Swahili language support to the application.
  • Added a new language code 'sw' to the list of supported languages.
  • Configured the language with its name, natural name, official status, and initial percentage.
  • Added an empty django.po file for the Swahili language.
src/pretalx/settings.py
src/pretalx/locale/sw/LC_MESSAGES/django.po
Updated multiple django.po files.
  • Updated the django.po files for the following languages: Arabic, Catalan, Czech, German (both formal and informal), Greek, Spanish, Mexican Spanish, French, Indonesian, Italian, Japanese, Korean, Dutch, Brazilian Portuguese, Portuguese, Russian, Slovenian, Swedish, Vietnamese, and Chinese (both simplified and traditional).
src/pretalx/locale/ar/LC_MESSAGES/django.po
src/pretalx/locale/ca/LC_MESSAGES/django.po
src/pretalx/locale/cs/LC_MESSAGES/django.po
src/pretalx/locale/de_DE/LC_MESSAGES/django.po
src/pretalx/locale/de_Formal/LC_MESSAGES/django.po
src/pretalx/locale/el/LC_MESSAGES/django.po
src/pretalx/locale/es/LC_MESSAGES/django.po
src/pretalx/locale/es_MX/LC_MESSAGES/django.po
src/pretalx/locale/fr_FR/LC_MESSAGES/django.po
src/pretalx/locale/id/LC_MESSAGES/django.po
src/pretalx/locale/it/LC_MESSAGES/django.po
src/pretalx/locale/ja_JP/LC_MESSAGES/django.po
src/pretalx/locale/ko/LC_MESSAGES/django.po
src/pretalx/locale/nl/LC_MESSAGES/django.po
src/pretalx/locale/pt_BR/LC_MESSAGES/django.po
src/pretalx/locale/pt_PT/LC_MESSAGES/django.po
src/pretalx/locale/ru/LC_MESSAGES/django.po
src/pretalx/locale/sl/LC_MESSAGES/django.po
src/pretalx/locale/sv/LC_MESSAGES/django.po
src/pretalx/locale/vi/LC_MESSAGES/django.po
src/pretalx/locale/zh_Hans/LC_MESSAGES/django.po
src/pretalx/locale/zh_Hant/LC_MESSAGES/django.po
Updated the django.pot file.
  • Updated the django.pot file.
src/pretalx/locale/django.pot

Assessment against linked issues

Issue Objective Addressed Explanation
#265 Add Swahili as a language option in event creation.
#265 Add Swahili as a language option in settings.
#265 Fix integration system with weblate. The PR only adds the Swahili language option. It does not address the integration with Weblate.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hongquan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please ensure the new language is added to the LANGUAGES setting in settings.py.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hongquan
Copy link
Member Author

@sourcery-ai: The LANGUAGES settings is dymamically computed from LANGUAGES_INFORMATION and already include Swahili.

@norbusan
Copy link
Member

Why are there soooooo many changes in unrelated files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Swahili as a language option and fix integration system with weblate
2 participants