Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less command to Docker image #284

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

hongquan
Copy link
Member

@hongquan hongquan commented Feb 26, 2025

Fixes #283
This PR also enables pretixuser to run any command with sudo. Before that, this user cannot run supervisorctl, cannot view the logs written down by supervisord.

How has this been tested?

Can use less with sudo:

image

With less, can search with highlight in logs

image

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Add the less command to the Docker image and grant the pretixuser unrestricted sudo privileges.

Build:

  • Add the less command to the Docker image.
  • Grant the pretixuser unrestricted sudo privileges to allow executing commands like supervisorctl and viewing logs.

Copy link

sourcery-ai bot commented Feb 26, 2025

Reviewer's Guide by Sourcery

This pull request adds the less command to the Docker image and grants the pretixuser unrestricted sudo privileges. The addition of less allows for enhanced log searching and viewing capabilities within the Docker container. The sudo privilege escalation for pretixuser addresses the previous inability to execute supervisorctl and access logs written by supervisord.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added the less command to the Docker image.
  • Installed the less package using apt-get.
Dockerfile
Granted the pretixuser unrestricted sudo privileges.
  • Modified the /etc/sudoers file to allow pretalxuser to execute any command with sudo without a password.
Dockerfile

Assessment against linked issues

Issue Objective Addressed Explanation
#283 Add less pager to the Docker container.
#283 Enable pretixuser to run any command with sudo.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker container should have less pager to help view long logs
1 participant