Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning: "Calling promisify on a function that returns a Promise is likely a mistake" #463

Closed
wants to merge 1 commit into from

Conversation

gzurbach
Copy link

Fixes #462

I tested this change locally in my project and it seems to work fine. However, I am not familiar enough with the codebase to understand potential side-effects with other configurations.

@titanism
Copy link
Contributor

Not merging since some consolidate exposed functions are sync or callback and need to be converted as such. Instead, a eslint code comment should be added to ignore this rule/deprecation notice.

@titanism titanism closed this Oct 29, 2024
@almeidx
Copy link

almeidx commented Oct 29, 2024

Not merging since some consolidate exposed functions are sync or callback and need to be converted as such. Instead, a eslint code comment should be added to ignore this rule/deprecation notice.

It's not a warning from ESLint. This is a warning shown during runtime (from a Node.js built-in function).
And since this is a deprecation warning, this should be addressed, even if not in the way that it was done in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Deprecation Warning: Calling promisify on a function that returns a Promise
4 participants