fix: windows compilation of hash maps tests and increase stack size avoiding segfaults #988
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvesz
changed the title
|
Ideally there would be a way to avoid the issues with the libs, instead of fixing them this way, but it seems to work. |
|
Also this may warrant adding the intel oneapi llvm compiler on windows to the compilers which work, but aren't tested in the readme. |
|
Yes, I agree that ideally this should be managed differently but I'm not aware of a better solution compared to what we found here. It is good that indeed, it enables full compliance on Windows for the tests. |
This was
linked to
issues
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #979 and #971 partially.
For intel compiler some dependencies with mvsc need to be managed.
Another problem is the stack memory size limit that needs to be increased for Windows.
cc @R-Goc @zoziha @jvdp1 @perazz