Adding Functionality to Create Policies Inside Policy Block #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR (fortinetdev/forti-sdk-go#8) pertains to Support Ticket #8512414 [EFN] and involves significant modifications to the Fortinet SDK. The changes were implemented to add support for the creation of policies inside the policy block in the Fortimanager terraform provider.
A new file, fmg/resource_packages_firewall_policy_block.go, has been introduced. This file, along with its associated call in fmg/provider.go, serves to create a new Terraform resource, "fortimanager_packages_firewall_policy_block". This novel resource permits the creation of a policy within the policy block, which is a departure from the existing policy package creation process.
Please take a moment to review these changes, particularly the new file and its corresponding function call. Your feedback is of utmost importance, especially in the context of the intended functionality and the proposed implementation.
The remaining changes, though seeming unrelated, were necessary adjustments to enable the compilation of a new custom provider: https://registry.terraform.io/providers/romanromanovv/fortimanager/latest. They do not directly contribute to the policy block functionality.
I welcome any comments, questions, or discussions related to this implementation. Thank you for your time and consideration.
Best Regards,