Addressed review comments:

On branch final_doc_changes_5_33 Your branch is up to date with 'origin/final_doc_changes_5_33'.
fortanix · Sep 25, 2024 · a9ecba7 · a9ecba7
1 parent d4c1d4c
commit a9ecba7
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 14 deletions.
diff --git a/docs/resources/acc_crypto_policy.md b/docs/resources/acc_crypto_policy.md
@@ -23,7 +23,7 @@ variable "acct_id" {
 resource "dsm_acc_crypto_policy" "name" {
   acct_id = var.acct_id
   cryptographic_policy = jsonencode({
-    legacy_policy = "allowed" # other values: prohibited and unprotect_only
+    legacy_policy = "allowed" # other accepted values: prohibited and unprotect_only
     key_ops = [
       "SIGN", "VERIFY", "ENCRYPT", "DECRYPT", "WRAPKEY", "UNWRAPKEY", "DERIVEKEY", "TRANSFORM", "MACGENERATE",
       "MACVERIFY", "EXPORT", "APPMANAGEABLE", "AGREEKEY", "ENCAPSULATE", "DECAPSULATE"
@@ -101,7 +101,7 @@ resource "dsm_acc_crypto_policy" "name" {
 resource "dsm_acc_crypto_policy" "name" {
   acct_id = var.acct_id
   cryptographic_policy = jsonencode({
-    legacy_policy = "prohibited" # other values: allowed and unprotect_only
+    legacy_policy = "prohibited" # other accepted values: allowed and unprotect_only
     key_ops = [
       "SIGN", "VERIFY", "ENCRYPT", "DECRYPT", "WRAPKEY", "UNWRAPKEY", "DERIVEKEY", "TRANSFORM", "MACGENERATE",
       "MACVERIFY", "EXPORT", "APPMANAGEABLE", "AGREEKEY", "ENCAPSULATE", "DECAPSULATE"

diff --git a/docs/resources/azure_group.md b/docs/resources/azure_group.md
@@ -17,7 +17,7 @@ Creates a Fortanix DSM group mapped to Azure Key Vault in the cluster as a resou
 resource "dsm_azure_group" "dsm_azure_group" {
   name            = "dsm_azure_group"
   description     = "Azure group"
-  url             = "https:#testfortanixterraform.vault.azure.net/"
+  url             = "https://testfortanixterraform.vault.azure.net/"
   tenant_id       = "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
   client_id       = "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
   subscription_id = "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"

diff --git a/docs/resources/csr.md b/docs/resources/csr.md
@@ -14,7 +14,7 @@ Generates a CSR from an existing private key within DSM.
 
 ```terraform
 # To use this resource, it is required to create a custom plugin in DSM first.
-# Copy the plugin from https:#github.com/fortanix/terraform-provider-dsm/blob/main/plugins/Terraform-Plugin-CSR.lua
+# Copy the plugin from https://github.com/fortanix/terraform-provider-dsm/blob/main/plugins/Terraform-Plugin-CSR.lua
 # Create the custom plugin in DSM 
 # Plugin title: "Terraform Plugin - CSR"
 

diff --git a/docs/resources/existing_group.md b/docs/resources/existing_group.md
@@ -61,7 +61,7 @@ resource "dsm_existing_group" "dsm_group" {
   name        = "dsm_group"
   description = "Update existing group"
   hmg = jsonencode({
-    url = "https:#sampleakv.vault.azure.net/"
+    url = "https://sampleakv.vault.azure.net/"
     tls = {
       mode = "required"
       validate_hostname : false

diff --git a/docs/resources/group_crypto_policy.md b/docs/resources/group_crypto_policy.md
@@ -18,7 +18,7 @@ resource "dsm_group" "group" {
   name = "group"
 }
 
-## Adding cryptographic policy to the group
+# Adding cryptographic policy to the group
 
 # This resource is an example of a crypto policy with all the permissions allowed.
 resource "dsm_group_crypto_policy" "group_crypto_policy" {
@@ -66,7 +66,7 @@ resource "dsm_group_crypto_policy" "group_crypto_policy" {
 }
 
 # This resource is an example of a crypto policy with some restrictions.
-# rsa, ec and dsa are defined beas null, hence they are not allowed to do any operations for rsa, ec and dsa.
+# rsa, ec and dsa are defined as null, hence they are not allowed to do any operations for rsa, ec and dsa.
 # Similarly, if others are not required in the use case, those values can be defined as null.
 resource "dsm_group_crypto_policy" "group_crypto_policy" {
   name = dsm_group.group.name

diff --git a/examples/resources/dsm_acc_crypto_policy/resource.tf b/examples/resources/dsm_acc_crypto_policy/resource.tf
@@ -8,7 +8,7 @@ variable "acct_id" {
 resource "dsm_acc_crypto_policy" "name" {
   acct_id = var.acct_id
   cryptographic_policy = jsonencode({
-    legacy_policy = "allowed" # other values: prohibited and unprotect_only
+    legacy_policy = "allowed" # other accepted values: prohibited and unprotect_only
     key_ops = [
       "SIGN", "VERIFY", "ENCRYPT", "DECRYPT", "WRAPKEY", "UNWRAPKEY", "DERIVEKEY", "TRANSFORM", "MACGENERATE",
       "MACVERIFY", "EXPORT", "APPMANAGEABLE", "AGREEKEY", "ENCAPSULATE", "DECAPSULATE"
@@ -86,7 +86,7 @@ resource "dsm_acc_crypto_policy" "name" {
 resource "dsm_acc_crypto_policy" "name" {
   acct_id = var.acct_id
   cryptographic_policy = jsonencode({
-    legacy_policy = "prohibited" # other values: allowed and unprotect_only
+    legacy_policy = "prohibited" # other accepted values: allowed and unprotect_only
     key_ops = [
       "SIGN", "VERIFY", "ENCRYPT", "DECRYPT", "WRAPKEY", "UNWRAPKEY", "DERIVEKEY", "TRANSFORM", "MACGENERATE",
       "MACVERIFY", "EXPORT", "APPMANAGEABLE", "AGREEKEY", "ENCAPSULATE", "DECAPSULATE"

diff --git a/examples/resources/dsm_azure_group/resource.tf b/examples/resources/dsm_azure_group/resource.tf
@@ -2,7 +2,7 @@
 resource "dsm_azure_group" "dsm_azure_group" {
   name            = "dsm_azure_group"
   description     = "Azure group"
-  url             = "https:#testfortanixterraform.vault.azure.net/"
+  url             = "https://testfortanixterraform.vault.azure.net/"
   tenant_id       = "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
   client_id       = "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"
   subscription_id = "XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX"

diff --git a/examples/resources/dsm_csr/resource.tf b/examples/resources/dsm_csr/resource.tf
@@ -1,5 +1,5 @@
 # To use this resource, it is required to create a custom plugin in DSM first.
-# Copy the plugin from https:#github.com/fortanix/terraform-provider-dsm/blob/main/plugins/Terraform-Plugin-CSR.lua
+# Copy the plugin from https://github.com/fortanix/terraform-provider-dsm/blob/main/plugins/Terraform-Plugin-CSR.lua
 # Create the custom plugin in DSM 
 # Plugin title: "Terraform Plugin - CSR"
 

diff --git a/examples/resources/dsm_existing_group/resource.tf b/examples/resources/dsm_existing_group/resource.tf
@@ -44,7 +44,7 @@ resource "dsm_existing_group" "dsm_group" {
   name        = "dsm_group"
   description = "Update existing group"
   hmg = jsonencode({
-    url = "https:#sampleakv.vault.azure.net/"
+    url = "https://sampleakv.vault.azure.net/"
     tls = {
       mode = "required"
       validate_hostname : false

diff --git a/examples/resources/dsm_group_crypto_policy/resource.tf b/examples/resources/dsm_group_crypto_policy/resource.tf
@@ -3,7 +3,7 @@ resource "dsm_group" "group" {
   name = "group"
 }
 
-## Adding cryptographic policy to the group
+# Adding cryptographic policy to the group
 
 # This resource is an example of a crypto policy with all the permissions allowed.
 resource "dsm_group_crypto_policy" "group_crypto_policy" {
@@ -51,7 +51,7 @@ resource "dsm_group_crypto_policy" "group_crypto_policy" {
 }
 
 # This resource is an example of a crypto policy with some restrictions.
-# rsa, ec and dsa are defined beas null, hence they are not allowed to do any operations for rsa, ec and dsa.
+# rsa, ec and dsa are defined as null, hence they are not allowed to do any operations for rsa, ec and dsa.
 # Similarly, if others are not required in the use case, those values can be defined as null.
 resource "dsm_group_crypto_policy" "group_crypto_policy" {
   name = dsm_group.group.name