Skip to content

Commit

Permalink
Change paths of private artifact dependencies to a public ones (#17)
Browse files Browse the repository at this point in the history
* - init

* - changed tests container buffer path

* - code review changes

* Revert "- code review changes"

This reverts commit 85c3ede.
  • Loading branch information
nshyrei authored Oct 7, 2024
1 parent 9c5f84f commit 4d3e1af
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build-app-tests-container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ FLAVOR=debug
if [ -z "$SKIP_RUNNING_TESTS" ]; then
make tests-container FLAVOR=$FLAVOR
TESTS_CONTAINER_TAG=$(cat build/nitro-$FLAVOR/tests-container-tag)
TESTS_CONTAINER_ECR="513076507034.dkr.ecr.us-west-1.amazonaws.com/development-images/$TESTS_CONTAINER_TAG"
TESTS_CONTAINER_ECR="513076507034.dkr.ecr.us-west-1.amazonaws.com/salmiac-github-ci/$TESTS_CONTAINER_TAG"

docker load -i build/nitro-$FLAVOR/salmiac-tests-container.tar.gz
docker tag $TESTS_CONTAINER_TAG $TESTS_CONTAINER_ECR
Expand Down
2 changes: 1 addition & 1 deletion docker/build-enclave-kernel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ set -exo pipefail
ARTIFACT_NAME="amzn-linux-nbd-v1.tar"
ARTIFACT_DIR="amzn-linux-nbd"
fetchartifacts() {
aws s3 cp s3://fortanix-internal-artifact-repository/salmiac/$ARTIFACT_NAME .
aws s3 cp s3://downloads.fortanix.com/salmiac/$ARTIFACT_NAME .
tar -xvf $ARTIFACT_NAME
}

Expand Down
2 changes: 1 addition & 1 deletion make/salmiac-tests-container.make
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ $(eval $(call make-cp-rule,$(REPO_ROOT)/tools/app-test-inrfa/bin/tests-container
$(eval $(call make-cp-rule,$(REPO_ROOT)/tools/app-test-infra/bin/tests-container-run.py,$(TESTS-STAGE-DIR)/tests-container-run.py))
$(eval $(call make-cp-rule,$(REPO_ROOT)/test/tests-container-salmiac/docker-config.json,$(TESTS-STAGE-DIR)/docker-config.json))
$(eval $(call make-cp-rule,$(REPO_ROOT)/tools/container-converter/target/$(FLAVOR)/container-converter,$(TESTS-STAGE-DIR)/container-converter))
$(eval $(call pull-s3,s3\://fortanix-internal-artifact-repository/salmiac/$(ENCLAVE-KERNEL-TAR),$(TESTS-STAGE-DIR)/$(ENCLAVE-KERNEL-TAR)))
$(eval $(call pull-s3,s3\://downloads.fortanix.com/salmiac/$(ENCLAVE-KERNEL-TAR),$(TESTS-STAGE-DIR)/$(ENCLAVE-KERNEL-TAR)))
$(eval $(call untar-pkg,$(TESTS-STAGE-DIR)/$(ENCLAVE-KERNEL-TAR),$(TESTS-STAGE-DIR)/amzn-linux-nbd))

# This generates the rules for copying the contents of tools/app-test-infra/python
Expand Down
4 changes: 2 additions & 2 deletions run-application-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ echo "AWS_CREDENTIALS=$(/usr/bin/base64 --wrap=0 < ~/.aws/credentials)" >> docke
ECR_PASSWORD=$(aws ecr get-login-password --region us-west-1)
echo "ECR_PASSWORD=$ECR_PASSWORD" >> docker-env

PARENT_IMAGE=513076507034.dkr.ecr.us-west-1.amazonaws.com/nitro-parent-base:1.1.1
PARENT_IMAGE=fortanix/nitro-parent-base:1.1.4
echo "PARENT_IMAGE=$PARENT_IMAGE" >> docker-env

ENCLAVE_IMAGE=513076507034.dkr.ecr.us-west-1.amazonaws.com/nitro-enclave-base:1.0.1
ENCLAVE_IMAGE=fortanix/nitro-enclave-base:1.0.2
echo "ENCLAVE_IMAGE=$ENCLAVE_IMAGE" >> docker-env

echo "FORTANIX_API_KEY=$FORTANIX_API_KEY" >> docker-env
Expand Down
2 changes: 1 addition & 1 deletion test/tests-container-salmiac/Dockerfile-salmiac-ub20
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM 513076507034.dkr.ecr.us-west-1.amazonaws.com/development-images/nitro-parent-base:1.1.4 as nitro-cli
FROM fortanix/nitro-parent-base:1.1.4 as nitro-cli

ARG PLATFORM
ARG FLAVOR
Expand Down

0 comments on commit 4d3e1af

Please sign in to comment.