Skip to content

Commit

Permalink
- code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
nshyrei committed Feb 20, 2024
1 parent 0dd0961 commit 0ca9f06
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-solution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
- name: Build Rust code
run: |
./build-solution.sh
./build-converter.sh
- name: Run Rust unit tests
env:
Expand Down
73 changes: 73 additions & 0 deletions .idea/workspace.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A confidential VM running unmodified container images in AWS [Nitro Enclaves](ht
Salmiac makes it possible to run an application in isolated compute environments to protect and securely process highly sensitive data.

By default bare Nitro Enclaves doesn't provide any networking capability outside of the enclave environment as well
as no persistent storage, meaning that all your data is lost when container image finishes it's execution.
as no persistent storage, meaning that all your data is lost when container image finishes its execution.

Salmiac enhances Nitro Enclaves by enabling networking for external communication and providing encrypted persistent storage.

Expand All @@ -28,7 +28,7 @@ Quick Start Guide
Follow [this](https://docs.docker.com/engine/install/) guide.


3. Setup your Nitro-enabled AWS EC2 instance:
3. Set up your Nitro-enabled AWS EC2 instance:
- Install docker on your EC2:
Follow step #2
- Install nitro-cli on your EC2:
Expand All @@ -51,7 +51,7 @@ Quick Start Guide
```bash
# Run from the root of the repository
cd salmiac
./build-solution.sh
./build-converter.sh
```

6. Create a simple conversion request json file
Expand Down
File renamed without changes.

0 comments on commit 0ca9f06

Please sign in to comment.