Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pki provider #9

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Update pki provider #9

merged 6 commits into from
Nov 6, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Nov 4, 2023

  • Update pki provider to use newer rustls to sync up with crypto provider.
  • No default feature on rustls in pki provider to avoid dependency on ring
  • Add a full example of using crypto and pki provider to create a TLS client.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (351ee99) 88.65% compared to head (88a9324) 88.90%.

❗ Current head 88a9324 differs from pull request most recent head 59c6b3d. Consider uploading reports for the commit 59c6b3d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   88.65%   88.90%   +0.24%     
==========================================
  Files          11       11              
  Lines        1111     1136      +25     
==========================================
+ Hits          985     1010      +25     
  Misses        126      126              
Files Coverage Δ
rustls-mbedpki-provider/src/lib.rs 64.86% <100.00%> (-0.47%) ⬇️
...ustls-mbedpki-provider/src/server_cert_verifier.rs 97.90% <100.00%> (+0.12%) ⬆️
rustls-mbedpki-provider/src/tests_common.rs 98.75% <100.00%> (-0.08%) ⬇️
...ustls-mbedpki-provider/src/client_cert_verifier.rs 92.30% <94.87%> (+0.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Taowyoo Taowyoo requested a review from s-arash November 6, 2023 17:43
Copy link
Collaborator

@s-arash s-arash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few things have changed it looks like in the new version.

@Taowyoo Taowyoo added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit 3225e03 Nov 6, 2023
Taowyoo added a commit that referenced this pull request Nov 6, 2023
@Taowyoo Taowyoo deleted the yx/update-pki branch November 6, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants