Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks #16

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Add benchmarks #16

merged 5 commits into from
Dec 7, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Dec 6, 2023

This PR closes #8 .

@Taowyoo Taowyoo added enhancement New feature or request CI CI related stuff dependencies Pull requests that update a dependency file labels Dec 6, 2023
@Taowyoo Taowyoo requested a review from s-arash December 6, 2023 20:18
@Taowyoo Taowyoo self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (003f727) 91.94% compared to head (8e13927) 92.37%.

Files Patch % Lines
rustls-mbedcrypto-provider/src/tls12.rs 66.66% 4 Missing ⚠️
rustls-mbedcrypto-provider/src/error.rs 0.00% 2 Missing ⚠️
rustls-mbedcrypto-provider/src/hmac.rs 88.23% 2 Missing ⚠️
rustls-mbedcrypto-provider/src/tls13.rs 66.66% 2 Missing ⚠️
rustls-mbedcrypto-provider/src/kx.rs 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   91.94%   92.37%   +0.42%     
==========================================
  Files          16       16              
  Lines        1812     1796      -16     
==========================================
- Hits         1666     1659       -7     
+ Misses        146      137       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@s-arash s-arash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are about 10-20 times slower than ring in crypto operations? 🤔
Is it because mbedtls is slow?

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Dec 7, 2023

So we are about 10-20 times slower than ring in crypto operations? 🤔 Is it because mbedtls is slow?

@s-arash Yes, mainly because mbedtls is slow.

@Taowyoo Taowyoo added this pull request to the merge queue Dec 7, 2023
Merged via the queue into master with commit 6849c5c Dec 7, 2023
13 of 14 checks passed
@Taowyoo Taowyoo deleted the yx/add-benchmarks branch December 7, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related stuff dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmark
2 participants