Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustls v0.22 #15

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Upgrade to rustls v0.22 #15

merged 2 commits into from
Dec 6, 2023

Conversation

s-arash
Copy link
Collaborator

@s-arash s-arash commented Dec 6, 2023

I also deleted some tests that were not relevant to us.

@s-arash s-arash requested a review from Taowyoo December 6, 2023 00:48
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a04c185) 94.08% compared to head (0e63f9c) 91.94%.

Files Patch % Lines
rustls-mbedcrypto-provider/src/tls12.rs 40.00% 6 Missing ⚠️
rustls-mbedcrypto-provider/src/tls13.rs 40.00% 3 Missing ⚠️
rustls-mbedcrypto-provider/src/lib.rs 91.66% 1 Missing ⚠️
...ustls-mbedpki-provider/src/server_cert_verifier.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   94.08%   91.94%   -2.15%     
==========================================
  Files          16       16              
  Lines        1810     1812       +2     
==========================================
- Hits         1703     1666      -37     
- Misses        107      146      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Taowyoo Taowyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change needed. Also it seems there is some syntax issue complained by clippy.

rustls-mbedcrypto-provider/src/tls12.rs Outdated Show resolved Hide resolved
@Taowyoo Taowyoo enabled auto-merge December 6, 2023 01:38
@Taowyoo Taowyoo self-requested a review December 6, 2023 18:20
@Taowyoo Taowyoo added this pull request to the merge queue Dec 6, 2023
Merged via the queue into fortanix:master with commit 003f727 Dec 6, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants