Letting enclaves keep track of time without usercalls #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulstrackx
force-pushed
the
raoul/rte-204-nightly-2024-11-21-insecure_time_through_rdtscp
branch
from
d7f36ca to
6510427
Compare
Taowyoo
reviewed
Dec 5, 2024
There was a problem hiding this comment.
I think we will need another PR after fortanix/rust-sgx#659 is merged and new versions of related crates are published.
Taowyoo
approved these changes
Dec 5, 2024
raoulstrackx
force-pushed
the
raoul/rte-204-nightly-2024-11-21-insecure_time_through_rdtscp
branch
from
6510427 to
2940827
Compare
Taowyoo
reviewed
Dec 13, 2024
| 'rustc-dep-of-std', | ||
| ], public = true } | ||
| insecure-time = { version = "0.1", git = "https://github.com/fortanix/rust-sgx.git", branch = "master", default-features = false, features = ["rustc-dep-of-std"] } |
There was a problem hiding this comment.
Suggest to update this finally after all rust-sgx side PRs are all merged and crate published
raoulstrackx
changed the base branch from
nightly-2024-11-21
to
dev-2024-11-21-snmalloc_and_insecure_time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGXv2 platforms support calling the rdtscp instruction inside an enclave. This PR enables such support for newly build SGX enclaves.
This code depends on code changes in the rust-sgx repository:
insecure-timecrate in various toolsOnce code is reviewed here, I'll try to upstream it.