Skip to content

Conversation

@Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Sep 12, 2025

This PR:

@Taowyoo Taowyoo linked an issue Sep 12, 2025 that may be closed by this pull request
@raoulstrackx
Copy link
Contributor

This seems complex. Can't we just match the error on Error::PCSError(StatusCode::Gone) and ignore it in the tests when it's gone? Creating a function resource_gone on Error would be nice :)

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Sep 15, 2025

This seems complex. Can't we just match the error on Error::PCSError(StatusCode::Gone) and ignore it in the tests when it's gone? Creating a function resource_gone on Error would be nice :)

Hi @raoulstrackx , PCCS behaves different from Intel PCS. It does not response Gone when evaluation number is old.
This is main reason for the complex approach here.
So I am considering update our PCCS code instead of this PR.

I think we can use my fix here temporarily f09a262

@raoulstrackx
Copy link
Contributor

Yes PCCS should definitely get an update to correctly report "Gone" when it needs to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix PCCS TcbEvaluationDataNumbers related tests

3 participants