Fix CI #561
Merged
Fix CI #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taowyoo
approved these changes
Feb 28, 2024
| @@ -418,8 +418,8 @@ impl<W: Write> SgxsWrite for W { | |||
| let mut buf = [0u8; 64]; | |||
| unsafe { | |||
| let (tag, headerdst) = buf.split_at_mut(8); | |||
| let tag = &mut *(&mut tag[0] as *mut _ as *mut u64); | |||
| let headerdst = &mut headerdst[0] as *mut _; | |||
| let tag = &mut *(&mut tag[0..8] as *mut _ as *mut u64); | |||
There was a problem hiding this comment.
Wow, so new nightly compiler will warn this ?
There was a problem hiding this comment.
Yes it surprised me too!
nshyrei
approved these changes
Feb 29, 2024
nshyrei
reviewed
Feb 29, 2024
| let tag = &mut *(&mut tag[0] as *mut _ as *mut u64); | ||
| let headerdst = &mut headerdst[0] as *mut _; | ||
| let tag = &mut *(&mut tag[0..8] as *mut _ as *mut u64); | ||
| let headerdst = &mut headerdst[0..56] as *mut _; |
There was a problem hiding this comment.
@raoulstrackx Where is this 56 byte size mentioned? I understand in the line above that 8 bytes translate to u64, but what is this type?
There was a problem hiding this comment.
It's size comes from how MRENCLAVE is being measured. See the sgxs documentation and Intel Manual vol 3D ch 36.4.1.1 At the Rust code level, there isn't one an explicit type for it. Based on what's being added (ECreate, Unsized,...) different types are used.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently broken due to a more intelligent nightly compiler and warnings being treated as errors. This PR fixes these errors.
Fixes #560