Fix em_app vulnerability
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `encrypt_buffer` and `decrypt_buffer` functions use the `rustc_serialize::from_hex` function, but it is not constant time and leads to secret dependent control flow. These functions shouldn't have been in the API in the first place, and are removed.
raoulstrackx
force-pushed
the
raoul/gh-553-fix_em_app_vulnerability
branch
from
1306317 to
7c46bec
Compare
zugzwang
approved these changes
Jan 16, 2024
gausk
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a (minor) security issue in
em-app. Theencrypt_bufferanddecrypt_bufferfunctions use therustc_serialize::from_hex()function on a cryptographic key, but from_hex has secret dependent control flow.This PR removes those functions and bumps the version of
em-appFixes #553