Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #552

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix CI #552

merged 1 commit into from
Jan 15, 2024

Conversation

raoulstrackx
Copy link
Contributor

Fix #551

ssavvides
ssavvides approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@ssavvides ssavvides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raoulstrackx
Copy link
Contributor Author

bors r=gausk,ssavvides

@raoulstrackx
Copy link
Contributor Author

bors ping

1 similar comment
@raoulstrackx
Copy link
Contributor Author

bors ping

@Taowyoo
Copy link
Collaborator

Taowyoo commented Jan 9, 2024 •
edited
Loading

@raoulstrackx
I guess bors public instance maybe already down. Because the words from https://bors.tech/newsletter/2023/06/30/tmib-78/:

As mentioned on May 1, bors-ng is deprecated. Bug fixes are still accepted, but new features are not. The public instance will go away once GitHub Merge Queues leave beta.

And GitHub merge queue is generally available

We need to migrate to Github Action now.
I have a in progress PR for this: #549

And we could use branch protection settings similar to:

@raoulstrackx raoulstrackx added this pull request to the merge queue Jan 15, 2024
Merged via the queue into master with commit 5ef6bf7 Jan 15, 2024
1 check passed
@Taowyoo Taowyoo deleted the raoul/gh-551-fix_ci branch January 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gausk gausk gausk approved these changes

@ssavvides ssavvides ssavvides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failure of rustc-serialize breaks CI
4 participants
@raoulstrackx @Taowyoo @ssavvides @gausk