Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable PKCS#5 #270

Closed
wants to merge 1 commit into from
Closed

Disable PKCS#5 #270

wants to merge 1 commit into from

Conversation

jhagborgftx
Copy link

  • Unset MBEDTLS_PKCS5_C
  • Do not generate bindings for pkcs5.h
  • Remove tests for pkcs5

This closes #265.

@jhagborgftx
Disable PKCS#5
8c6374e 
* Unset MBEDTLS_PKCS5_C
* Do not generate bindings for pkcs5.h
* Remove tests for pkcs5
@jethrogb
Copy link
Member

I don't think this can be done separately from #213 due to API compatibility issues.

@Taowyoo
Copy link
Collaborator

Taowyoo commented Jul 18, 2023

From #213, you can see that although I removed the support of pkcs12 support in rust side, I still turn on the C define of it because some other code in C side is actually using pkcs12 (mainly in TLS for parse certificates). And this also applies to pkcs5.

And also the related function pbkdf2_hmac which used pkcs5_pbkdf2_hmac_ext is currently used by our internal projects.
So I think this issue need to be put off or declined.

I will close this PR, and keep track the discussion in:

@Taowyoo Taowyoo closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrogb jethrogb Awaiting requested review from jethrogb

@Taowyoo Taowyoo Awaiting requested review from Taowyoo

@MihirLuthra MihirLuthra Awaiting requested review from MihirLuthra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable PKCS5 module
3 participants
@jhagborgftx @jethrogb @Taowyoo