Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenAPI v3.1 'type' array syntax #5

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add support for OpenAPI v3.1 'type' array syntax #5

merged 1 commit into from
Jul 4, 2024

Conversation

mkrause
Copy link
Collaborator

@mkrause mkrause commented Jul 4, 2024 •
edited
Loading

Resolves #4

@mkrause
Copy link
Collaborator Author

mkrause commented Jul 4, 2024

Currently this is always generating a Union when there's a type array (with 2+ elements). We could also consider special casing type: ['null', <T>] to generate S.NullOr.

@mkrause mkrause requested a review from imadbakir July 4, 2024 17:48
midhun-pk
midhun-pk approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@midhun-pk midhun-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

imadbakir
imadbakir approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@imadbakir imadbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mkrause mkrause merged commit 8b0acca into master Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midhun-pk midhun-pk midhun-pk approved these changes

@imadbakir imadbakir imadbakir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support OpenAPI v3.1 type array syntax
3 participants
@mkrause @imadbakir @midhun-pk