Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chromatic integration for visual testing #53

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Add Chromatic integration for visual testing #53

merged 7 commits into from
Dec 11, 2024

Conversation

mkrause
Copy link
Collaborator

@mkrause mkrause commented Dec 10, 2024 •
edited
Loading

  • Add npm run chromatic
  • Add Chromatic CI workflow, so that visual tests are run on every change
  • Add Chromatic Storybook add-on

Also refactors the tsconfig.*.json files so that we properly type check files outside of src and app as well.

@mkrause mkrause self-assigned this Dec 10, 2024
@mkrause mkrause marked this pull request as ready for review December 10, 2024 21:22
@mkrause mkrause changed the title Add chromatic integration Add Chromatic integration Dec 10, 2024
@mkrause mkrause changed the title Add Chromatic integration Add Chromatic integration for visual testing Dec 10, 2024
@mkrause mkrause merged commit 7565188 into master Dec 11, 2024
3 checks passed
@mkrause mkrause deleted the mkrause/241210-chromatic branch December 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nighto nighto nighto approved these changes

Assignees

@mkrause mkrause

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkrause @nighto