Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React v19 stable #43

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

mkrause
Copy link
Collaborator

@mkrause mkrause commented Dec 5, 2024

Upgrades to React v19 stable, which was just released:

https://react.dev/blog/2024/12/05/react-19

I tried to see if I could remove the --force workaround for peer dependencies, however this is still not possible due to the following two dependencies:

  • @storybook/addon-designs: Open issue for it here.
  • vite-css-modules: This one actually doesn't conflict with React, but with Vite v6. No issue for it yet I believe, but related discussion here. Perhaps we should consider downgrading to Vite v5 for now?

@mkrause mkrause requested a review from YounesChellaf December 5, 2024 22:38
@mkrause mkrause self-assigned this Dec 5, 2024
@mkrause mkrause merged commit 30c1db3 into master Dec 5, 2024
2 checks passed
@mkrause mkrause deleted the mkrause/241205-react-19-stable branch December 5, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants